save-buffer commented on a change in pull request #12537:
URL: https://github.com/apache/arrow/pull/12537#discussion_r824957311
##########
File path: cpp/src/arrow/compute/exec/tpch_node.cc
##########
@@ -0,0 +1,3836 @@
+#include "arrow/compute/exec/tpch_node.h"
+#include "arrow/util/make_unique.h"
+#include "arrow/util/future.h"
+#include "arrow/util/unreachable.h"
+
+#include <algorithm>
+#include <bitset>
+#include <cstring>
+#include <random>
+#include <vector>
+#include <memory>
+#include <mutex>
+#include <queue>
+#include <unordered_set>
+
+namespace arrow
+{
+ using internal::checked_cast;
+
+ namespace compute
+ {
+ class TpchText
Review comment:
The spec defines generating comments as a "text string"
```
The term text string[min, max] represents a substring of a 300 MB string
populated according to the pseudo text grammar defined in Clause 4.2.2.14. The
length of the substring is a random number between min and max inclusive. The
substring offset is randomly chosen.
```
It does also refer to it as "pseudotext" at some points, so I could name it
like "TpchPseudotext" or something. I'll add a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
