yjshen commented on a change in pull request #1987:
URL: https://github.com/apache/arrow-datafusion/pull/1987#discussion_r825378707



##########
File path: datafusion/src/execution/context.rs
##########
@@ -1220,6 +1233,74 @@ impl FunctionRegistry for ExecutionContextState {
     }
 }
 
+/// Task Context Properties
+pub enum TaskProperties {

Review comment:
       I think this depends on how will `TaskProperties` be populated and 
lately used. If we are asking about the ability to adjust configs on a `task` 
basis, then a combination is needed. 
   
   Otherwise, we could do branching with `TaskProperties` like:
   ```rust
   impl TaskProperties {
       fn conf(&self, conf_key: impl Into<String>) -> String {
           "".to_owned()
       }
   
       fn typed_conf<T>(&self, conf_key: impl Into<String>) -> T {
           T::new()
       }
   
       fn batch_size(&self) -> usize {
           self.typed_conf("batch_size")
       }
   }
   ``` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to