kou commented on a change in pull request #12614:
URL: https://github.com/apache/arrow/pull/12614#discussion_r825509716



##########
File path: ruby/red-arrow/ext/arrow/converters.hpp
##########
@@ -761,8 +773,6 @@ namespace red_arrow {
     VISIT(Time32)
     VISIT(Time64)
     VISIT(Timestamp)
-    // TODO
-    // VISIT(Interval)

Review comment:
       Ah, we need to implement dictionary array cases with tests.
   Could you revert this change and open a new JIRA issue for adding tests of 
`Arrow::DictionaryArray#values` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to