save-buffer commented on a change in pull request #12605:
URL: https://github.com/apache/arrow/pull/12605#discussion_r826247125
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -1844,10 +1844,14 @@ macro(build_gtest)
set(GTEST_VENDORED TRUE)
set(GTEST_CMAKE_CXX_FLAGS ${EP_CXX_FLAGS})
- if(CMAKE_BUILD_TYPE MATCHES DEBUG)
- set(CMAKE_GTEST_DEBUG_EXTENSION "d")
+ if(NOT CMAKE_GENERATOR STREQUAL Xcode)
Review comment:
Now it seems to be not evaluating it
```
ninja: error: 'googletest_ep-prefix/lib/libgtest$<$<CONFIG:Debug>:d>.dylib',
needed by 'debug/libarrow_testing.800.0.0.dylib', missing and no known rule to
make it
```
I think generator expressions may be unnecessary overall, everything is
known at configuration-time, so there's no need to evaluate anything at
build-time. Multiconfiguration generators always want the flag set, and
single-configuration generators only want it set in debug mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
