lukecwik commented on a change in pull request #11199: [BEAM-9562] Update Timer
encoding to V2
URL: https://github.com/apache/beam/pull/11199#discussion_r397213244
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -718,9 +726,15 @@ message StandardCoders {
// 1: 80 00 00 00 00 00 00 01
// 256: 80 00 00 00 00 00 01 00
// 9223372036854775807: FF FF FF FF FF FF FF FF
- // payload - user defined data, uses the component coder
- // Components: Coder for the payload.
- TIMER = 4 [(beam_urn) = "beam:coder:timer:v1"];
+ //
+ // hold timestamp - similar to fire timestamp, but stands for the
+ // watermark the timer is expected to hold.
+ //
+ // windows - uses the component coder.
+ //
+ // paneinfo - similar to how paneinfo gets encoded in WindowedValue.
+ // Components: Coder for the user key, coder for the windows,
+ TIMER = 4 [(beam_urn) = "beam:coder:timer:v2"];
Review comment:
You don't need to change this to v2 since these are not stable yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
