robertwb commented on a change in pull request #11199: [BEAM-9562] Update Timer
encoding to V2
URL: https://github.com/apache/beam/pull/11199#discussion_r397328635
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -609,16 +609,20 @@ message Elements {
// represents the producer of these timers.
string transform_id = 2;
+ // (Optional) The local timer family name used to identify the associated
+ // timer family specification
+ string timer_family_tag = 3;
Review comment:
We should agree on terminology. The "family" represents the set of timers,
within that one has multiple [dynamic] tags. I would call this
`timer_family_id`.
We should not have both `timer_specs` and `timer_family_specs`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
