rohdesamuel commented on a change in pull request #11163: [BEAM-9548] Add
better error handling to the TestStreamServiceController
URL: https://github.com/apache/beam/pull/11163#discussion_r397342416
##########
File path:
sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py
##########
@@ -166,13 +169,15 @@ def _wait_until_file_exists(self, timeout_secs=30):
# Wait for up to `timeout_secs` for the file to be available.
start = time.time()
- path = os.path.join(self._cache_dir, *self._labels)
- while not os.path.exists(path):
+ while not os.path.exists(self._path):
time.sleep(1)
if time.time() - start > timeout_timestamp_secs:
+ from apache_beam.runners.interactive.pipeline_instrument import
CacheKey
+ pcollection_var = CacheKey.from_str(self._labels[-1]).var
Review comment:
Yeah, because these are Python variables, they have very strict naming
conventions which is ok to use for file names (alphanumeric with the addition
of an underscore).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
