pabloem commented on a change in pull request #11206: [BEAM-9598] Ensuring
_CustomBigQuerySource ValueProvider is only checked when strictly needed
URL: https://github.com/apache/beam/pull/11206#discussion_r397518601
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -638,7 +638,6 @@ def __init__(
self.kms_key = kms_key
self.split_result = None
- @check_accessible(['query'])
Review comment:
The query path will still error out if a query is not provided to the
template, but it will work fine when it is provided. There are tests for BQ
that use the `query` path (see [1],[2])
[1]
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/big_query_query_to_table_pipeline.py#L82-L87
[2]
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/big_query_query_to_table_it_test.py#L158-L179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
