boyuanzz commented on a change in pull request #11216: [BEAM-9562] Remove
TimerSpec from ParDoPayload
URL: https://github.com/apache/beam/pull/11216#discussion_r398011965
##########
File path: sdks/python/apache_beam/transforms/userstate.py
##########
@@ -141,6 +143,13 @@ def __init__(self, name, time_domain):
def __repr__(self):
return '%s(%s)' % (self.__class__.__name__, self.name)
+ def to_timer_family_runner_api(self, context):
Review comment:
I'm working on the Java changes meanwhile having some python tests to run to
catch any breakages. Changing to `to_runner_api` is the next step. We should
also remove `TimerSpec` definition from proto as long as nowhere else uses it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
