Hannah-Jiang commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398088883
########## File path: licenses/go/bufio/LICENSE ########## @@ -0,0 +1,27 @@ +Copyright (c) 2009 The Go Authors. All rights reserved. Review comment: > > I'll second the comment that we should not include the list of license files in the beam repository itself, but just add the script to the container build process to install them into the container. > > I agree. It would seem better for all languages to add the license retrieval to the container build script. I will make this change in the next commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
