ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213#issuecomment-604169079 Tests are failing because in some places, `JobServiceStub` instead of `JobServiceServicer`. `JobServiceStub` does not accept the `context` argument, while `JobServiceServicer` does. (I find this strange, because I assumed that if they have the same methods, those methods would have the same signature. Otherwise it seems like a violation of [LSP](https://en.wikipedia.org/wiki/Liskov_substitution_principle).) Since `JobServiceServicer` will fail anyway because none of its methods are implemented, I suppose it is okay to keep the status quo. Unless there is some Python magic I can use to fix this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
