lukecwik commented on a change in pull request #11184: [BEAM-4374] Update
protos related to MonitoringInfo.
URL: https://github.com/apache/beam/pull/11184#discussion_r398856669
##########
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/metrics/MonitoringInfoMatchers.java
##########
@@ -76,17 +63,20 @@ public void describeTo(Description description) {
* Matches a {@link MonitoringInfo} with that has the set fields in the
provide MonitoringInfo.
*
* <p>This is useful for tests which do not want to match the specific value
(execution times).
- * Currently this will only check for URNs, labels, type URNs and
int64Values.
+ * Currently this will only check for URNs, labels, type URNs and {@code
beam:coder:varint:v1}
+ * encoded values.
*/
- public static TypeSafeMatcher<MonitoringInfo> valueGreaterThan(final long
value) {
+ public static TypeSafeMatcher<MonitoringInfo>
valueGreaterThanOrEqualTo(final long value) {
Review comment:
Renamed to `counterValueGreaterThanOrEqualTo`
Also fixed comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
