aaltay commented on issue #11226: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11226#issuecomment-605098171
 
 
   > @amaliujia appears that test looks for specific strings in the exception 
(always a recipe for a brittle test). I changed "event time timer" to 
"event-time timer" which broke that test. Will fix.
   
   Agreed, it is brittle test.
   
   @reuvenlax are you planning to fix the test, or could @amaliujia send a 
fixup commit here to change "event-time" to "event time"? This is only release 
blocking issue currently, I would like to unblock it sooner.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to