tvalentyn commented on a change in pull request #11265: Fix a Py2/3
incompatibility in profiler.
URL: https://github.com/apache/beam/pull/11265#discussion_r400511384
##########
File path: sdks/python/apache_beam/utils/profiler.py
##########
@@ -88,7 +88,11 @@ def __exit__(self, *args):
self.profile_output = dump_location
if self.log_results:
- s = io.StringIO()
+ try:
+ import StringIO # Python 2
Review comment:
There are several keywords we'll have to look for during this cleanup.
"Python 2" should be one of them, that's why I added it. Tracking all possible
keywords to search in https://issues.apache.org/jira/browse/BEAM-7372.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
