robinyqiu commented on a change in pull request #11268: [BEAM-9179] Clean up
code in ZetaSQLDialectSpecTest
URL: https://github.com/apache/beam/pull/11268#discussion_r400555614
##########
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##########
@@ -2215,51 +2215,152 @@ public void testZetaSQLNestedQueryFive() {
pipeline.run().waitUntilFinish(Duration.standardMinutes(PIPELINE_EXECUTION_WAITTIME_MINUTES));
}
+ /////////////////////////////////////////////////////////////////////////////
+ // TIMESTAMP type tests
+ /////////////////////////////////////////////////////////////////////////////
+
@Test
- @Ignore("Does not support DATE_ADD and TIME_ADD.")
- public void testDateAndTimeAddSub() {
Review comment:
This ignored test got removed in this cleanup PR. But I will add it back and
make it working soon once we support DATE and TIME types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
