iemejia commented on issue #11263: [BEAM-9325] Override proper write method in UnownedOutputStream URL: https://github.com/apache/beam/pull/11263#issuecomment-606735293 Yes > What a terrible choice for the FilterOutputStream implementation. Reading the javadoc they clearly state that everyone who subclasses it needs to provide the optimal `write(byte[], int, int)` method. Also double checked grepcode for the source and they write one byte at a time. > > I was unaware of the FilterOutputStream problem when writing this. Yes this was a surprise to me too, kind of unexpected, but glad that @lukemin89 found the issue. Did you find it via some static analysis or just by performance 'luck' ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
