tvalentyn commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies for Python URL: https://github.com/apache/beam/pull/11067#discussion_r401244854
########## File path: sdks/python/container/Dockerfile ########## @@ -51,16 +51,20 @@ RUN ln -s /usr/bin/ccache /usr/local/bin/gcc RUN ccache --set-config=sloppiness=file_macro && ccache --set-config=hash_dir=false COPY target/apache-beam.tar.gz /opt/apache/beam/tars/ +ADD target/license_scripts /tmp/license_scripts/ Review comment: COPY is preferred over ADD. Can we remove usages of ADD to reduce cognitive load on people who might think why are we using sometimes COPY and sometimes ADD? See: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
