vnorigoog commented on issue #11183: [BEAM-8889]add experiment flag use_grpc_for_gcs URL: https://github.com/apache/beam/pull/11183#issuecomment-606959315 That is a real problem. unused variable "gcsOptions" Thanks, Luke. could you please issue "Run Java PreCommit" again. I am trying to understand 1. why local build didn't show this error when spotbugs ran on it. 2. why didn't I see this error on github you saw. I should have. I wonder if I didn't look in the right place. not happy with myself On Tue, Mar 31, 2020 at 4:50 PM Lukasz Cwik <[email protected]> wrote: > It looks like spotbugs is failing in the Java PreCommit with: > > Dead store to gcsOptions in org.apache.beam.sdk.extensions.gcp.util.GcsUtil$GcsUtilFactory.create(PipelineOptions, Storage, HttpRequestInitializer, ExecutorService, Integer) > Bug type DLS_DEAD_LOCAL_STORE (click for details) > In class org.apache.beam.sdk.extensions.gcp.util.GcsUtil$GcsUtilFactory > In method org.apache.beam.sdk.extensions.gcp.util.GcsUtil$GcsUtilFactory.create(PipelineOptions, Storage, HttpRequestInitializer, ExecutorService, Integer) > Local variable named gcsOptions > At GcsUtil.java:[line 115] > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/11183#issuecomment-606946300>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALRAMQU6NKEJDI3ZY46PCHTRKJ6T3ANCNFSM4LQRRJQQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
