robertwb commented on a change in pull request #11229: [BEAM-9608] Increasing
scope of context managers for FnApiRunner
URL: https://github.com/apache/beam/pull/11229#discussion_r401828861
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -511,87 +509,32 @@ def _add_residuals_and_channel_splits_to_deferred_inputs(
def _run_stage(self,
runner_execution_context, # type:
execution.FnApiRunnerExecutionContext
- stage, # type: translations.Stage
+ bundle_context_manager, # type:
execution.BundleContextManager
Review comment:
It's odd that _run_stage no longer takes as a parameter the stage to run.
Perhaps bundle_context_manager (and its class?) should be named stage_context
or similar?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
