chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates
Python SDK to handle remote SDK coders and preserve tags added by remote SDKs
and propagate restriction coders.
URL: https://github.com/apache/beam/pull/11185#discussion_r400601327
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -925,8 +970,11 @@ def run_ParDo(self, transform_node, options):
(transform_proto.spec.urn == common_urns.primitives.PAR_DO.urn or
use_unified_worker)):
# Patch side input ids to be unique across a given pipeline.
- if (label_renames and
- transform_proto.spec.urn == common_urns.primitives.PAR_DO.urn):
+ # This should not be done for external transforms since external SDKs may
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
