chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates
Python SDK to handle remote SDK coders and preserve tags added by remote SDKs
and propagate restriction coders.
URL: https://github.com/apache/beam/pull/11185#discussion_r400604613
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -995,10 +1044,13 @@ def run_ParDo(self, transform_node, options):
# The assumption here is that all outputs will have the same typehint
# and coder as the main output. This is certainly the case right now
# but conceivably it could change in the future.
+ encoding = self._get_encoded_output_coder(
+ transform_node,
+ output_tag=side_tag) if external_transform else step.encoding
Review comment:
We don't have to. Previously we were using same encoding for all outputs for
Python but seems like we can just generalize this without issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
