TheNeuralBit commented on a change in pull request #11290: [BEAM-9670] Fix
nullability widening in CoGroup key resolution
URL: https://github.com/apache/beam/pull/11290#discussion_r402450787
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamSetOperatorRelBase.java
##########
@@ -63,16 +62,6 @@ public BeamSetOperatorRelBase(BeamRelNode beamRelNode,
OpType opType, boolean al
inputs);
PCollection<Row> leftRows = inputs.get(0);
PCollection<Row> rightRows = inputs.get(1);
- Schema leftSchema = leftRows.getSchema();
- Schema rightSchema = rightRows.getSchema();
- if (!leftSchema.typesEqual(rightSchema)) {
- throw new IllegalArgumentException(
- "Can't intersect two tables with different schemas."
- + "lhsSchema: "
- + leftSchema
- + " rhsSchema: "
- + rightSchema);
- }
Review comment:
Shouldn't we still verify that the schemas have equivalent types without
nullability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
