lukecwik commented on a change in pull request #11205: [BEAM-9578] Enumerating
artifacts is too expensive in Java
URL: https://github.com/apache/beam/pull/11205#discussion_r402482918
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -215,22 +221,76 @@ public static Environment createProcessEnvironment(
}
ImmutableList.Builder<ArtifactInformation> filesToStage =
ImmutableList.builder();
+ ImmutableMap.Builder<String, Function<ArtifactInformation,
ArtifactInformation>>
+ lazyArtifactsBuilder = ImmutableMap.builder();
for (String path : pathsToStage) {
File file = new File(path);
- if (new File(path).exists()) {
- // Spurious items get added to the classpath. Filter by just those
that exist.
- if (file.isDirectory()) {
- // Zip up directories so we can upload them to the artifact service.
- try {
- filesToStage.add(createArtifactInformation(zipDirectory(file)));
- } catch (IOException e) {
- throw new RuntimeException(e);
- }
- } else {
- filesToStage.add(createArtifactInformation(file));
- }
+ // Spurious items get added to the classpath. Filter by just those that
exist.
+ if (file.exists()) {
+ String id = UUID.randomUUID().toString();
Review comment:
Note that you could put one ID into the map for the entire list of files if
you allowed ResolutionFn to return a List/Collection of artifacts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
