robertwb commented on a change in pull request #11185: [BEAM-8019] Updates
Python SDK to handle remote SDK coders and preserve tags added by remote SDKs
and propagate restriction coders.
URL: https://github.com/apache/beam/pull/11185#discussion_r402672185
##########
File path: sdks/python/apache_beam/coders/coders.py
##########
@@ -1383,22 +1385,50 @@ def from_runner_api_parameter(payload, components,
context):
write_state_threshold=int(payload))
-class RunnerAPICoderHolder(Coder):
+class CoderElementType(typehints.TypeConstraint):
+ """An element type that just holds a coder proto."""
+ def __init__(self, coder_proto, context):
+ self.coder_proto = coder_proto
Review comment:
Logically the ElementType should hold the ExternalCoder, and the
ExternalCoder should hold the proto. (This will also help some issues where
coders are requested manually and then not respected.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
