kamilwu commented on a change in pull request #11086: [BEAM-8910] Make custom
BQ source read from Avro
URL: https://github.com/apache/beam/pull/11086#discussion_r404000153
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -663,14 +662,10 @@ def split(self, desired_bundle_size,
start_position=None, stop_position=None):
self._setup_temporary_dataset(bq)
self.table_reference = self._execute_query(bq)
- schema, metadata_list = self._export_files(bq)
+ unused_schema, metadata_list = self._export_files(bq)
Review comment:
This is great! That would mean that we can safely remove `_JsonToDictCoder`.
Do you think you can do this as a part of this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
