iemejia commented on a change in pull request #11037: [BEAM-9434] performance
improvements reading many Avro files in S3
URL: https://github.com/apache/beam/pull/11037#discussion_r404053396
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/GroupCombineFunctions.java
##########
@@ -184,11 +184,11 @@
/** An implementation of {@link Reshuffle} for the Spark runner. */
public static <T> JavaRDD<WindowedValue<T>> reshuffle(
- JavaRDD<WindowedValue<T>> rdd, WindowedValueCoder<T> wvCoder) {
+ JavaRDD<WindowedValue<T>> rdd, WindowedValueCoder<T> wvCoder, int
numPartitions) {
Review comment:
Can you please let this method how it was before and better, and do `int
numPartitions = Math.max(rdd.context().defaultParallelism(),
rdd.getNumPartitions());` inside of it. That way you don't need to replicate
the change in the different translators..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
