lukecwik commented on a change in pull request #11235: [BEAM-9618] Pull bundle
descriptors.
URL: https://github.com/apache/beam/pull/11235#discussion_r404241747
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/FnApiControlClientPoolServiceTest.java
##########
@@ -120,4 +121,16 @@ public void onCompleted() {
latch.await();
assertThat(sawComplete.get(), is(true));
}
+
+ @Test
+ public void testUnknownBundle() throws Exception {
+ BeamFnApi.GetProcessBundleDescriptorRequest request =
+ BeamFnApi.GetProcessBundleDescriptorRequest.newBuilder()
+ .setProcessBundleDescriptorId("missing")
+ .build();
+ StreamObserver<BeamFnApi.ProcessBundleDescriptor> responseObserver =
mock(StreamObserver.class);
+ controlService.getProcessBundleDescriptor(request, responseObserver);
+
+ verify(responseObserver).onError(any(StatusException.class));
Review comment:
Validate the "not found" shows up in the status message and/or status code
to ensure that we got the right StatusException
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
