iemejia commented on a change in pull request #11028: BEAM-2546 Beam IO for InfluxDB URL: https://github.com/apache/beam/pull/11028#discussion_r404218978
########## File path: sdks/java/io/influxdb/src/test/java/org/apache/beam/sdk/io/influxdb/InfluxDBIOIT.java ########## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.influxdb; + +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.io.common.IOTestPipelineOptions; +import org.apache.beam.sdk.options.Default; +import org.apache.beam.sdk.options.Description; +import org.apache.beam.sdk.options.PipelineOptionsFactory; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.transforms.Count; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.values.PCollection; +import org.influxdb.InfluxDB; +import org.influxdb.InfluxDBFactory; +import org.influxdb.dto.Query; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** + * A test of {@link org.apache.beam.sdk.io.influxdb.InfluxDBIO} on an independent InfluxDB instance. + * + * <p>This test requires a running instance of InfluxDB. Pass in connection information using + * PipelineOptions: + * + * <pre> + * ./gradlew integrationTest -p sdks/java/io/influxdb -DintegrationTestPipelineOptions='[ + * "--influxdburl=http://localhost:8086";, + * "--infuxDBDatabase=mypass", + * "--username=username" + * "--password=password"]' + * --tests org.apache.beam.sdk.io.influxdb.InfluxDBIOIT + * -DintegrationTestRunner=direct + * </pre> + */ +@RunWith(JUnit4.class) +public class InfluxDBIOIT { + + private static InfluxDBPipelineOptions options; + + @Rule public final TestPipeline writePipeline = TestPipeline.create(); + @Rule public final TestPipeline readPipeline = TestPipeline.create(); + + /** InfluxDBIO options. */ + public interface InfluxDBPipelineOptions extends IOTestPipelineOptions { + @Description("InfluxDB host (host name/ip address)") + @Default.String("http://localhost:8086";) + String getInfluxDBURL(); + + void setInfluxDBURL(String value); + + @Description("Username for InfluxDB") + @Default.String("superadmin") + String getInfluxDBUserName(); + + void setInfluxDBUserName(String value); + + @Description("Password for InfluxDB") + @Default.String("supersecretpassword") + String getInfluxDBPassword(); + + void setInfluxDBPassword(String value); + + @Description("InfluxDB database name") + @Default.String("db0") + String getDatabaseName(); + + void setDatabaseName(String value); + } + + @BeforeClass + public static void setUp() { + PipelineOptionsFactory.register(InfluxDBPipelineOptions.class); + options = TestPipeline.testingPipelineOptions().as(InfluxDBPipelineOptions.class); + } + + @After + public void clear() { + try (InfluxDB connection = + InfluxDBFactory.connect( + options.getInfluxDBURL(), + options.getInfluxDBUserName(), + options.getInfluxDBPassword())) { + connection.query(new Query("DROP DATABASE \"" + options.getDatabaseName() + "\"")); + } + } + + @Before + public void initTest() { + try (InfluxDB connection = + InfluxDBFactory.connect( + options.getInfluxDBURL(), + options.getInfluxDBUserName(), + options.getInfluxDBPassword())) { + connection.query(new Query("CREATE DATABASE \"" + options.getDatabaseName() + "\"")); + } + } + + @Test + public void testWriteAndRead() { + final int noofElementsToReadAndWrite = 1000; + writePipeline + .apply("Generate data", Create.of(GenerateData.getMetric(noofElementsToReadAndWrite))) + .apply( + "Write data to InfluxDB", + InfluxDBIO.write() + .withConfiguration( + InfluxDBIO.DataSourceConfiguration.create( + options.getInfluxDBURL(), + options.getInfluxDBUserName(), + options.getInfluxDBPassword())) + .withDatabase(options.getDatabaseName()) + .withSslInvalidHostNameAllowed(false) + .withSslEnabled(false)); + writePipeline.run().waitUntilFinish(); + PCollection<String> readVals = Review comment: s/readVals/values ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
