aaltay commented on a change in pull request #11338: [BEAM-7923] Screendiff Integration Tests URL: https://github.com/apache/beam/pull/11338#discussion_r405182991
########## File path: sdks/python/apache_beam/runners/interactive/testing/integration/tests/init_square_cube_test.py ########## @@ -0,0 +1,37 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Integration tests for interactive beam.""" +# pytype: skip-file + +from __future__ import absolute_import + +import unittest + +from apache_beam.runners.interactive.testing.integration.screen_diff import BaseTestCase + + [email protected]( + BaseTestCase.should_skip(), + '[interactive] and [interactive_test] dependency are both required.') +class InitSquareCubeTest(BaseTestCase): + def test_init_square_cube_notebook(self): + self.assert_notebook('init_square_cube') Review comment: High level question, do we need to compare that pixels did not change with chnages? What benefit do we get from it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
