lukecwik commented on a change in pull request #11336: [BEAM-9718] Updates
comments for WINDOWED_VALUE coder
URL: https://github.com/apache/beam/pull/11336#discussion_r405776839
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -739,9 +739,44 @@ message StandardCoders {
// Components: None
GLOBAL_WINDOW = 7 [(beam_urn) = "beam:coder:global_window:v1"];
- // Encodes an element, the window the value is in, the timestamp of the
element, and the pane
- // of the element
- // Components: The element coder and the window coder, in that order
+ // Encodes an element, the windows it is in, the timestamp of the element,
+ // and the pane of the element. The encoding is represented as:
+ // timestamp windows pane element
+ // timestamp - A big endian 8 byte integer representing
millis-since-epoch.
+ // The encoded representation is shifted so that the byte
representation
+ // of negative values are lexicographically ordered before the byte
+ // representation of positive values.
+ //
+ // windows - For windows [w1...wN], the encoding is
+ // fixed32(N) encode(w1) ... encode(wN)
Review comment:
The iterable is encoded using the beam:coder:iterable:v1 format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
