angoenka commented on a change in pull request #11355: [BEAM-9727]
Automatically set required experiment flags for dataflow …
URL: https://github.com/apache/beam/pull/11355#discussion_r405880602
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -566,6 +572,17 @@ def run_pipeline(self, pipeline, options):
result.metric_results = self._metrics
return result
+ def _maybe_add_unified_worker_missing_options(self, options):
+ # set default beam_fn_api and use_unified_worker experiment if
+ # 'use_runner_v2' experiment flag exists, no-op otherwise.
+ experiments = options.view_as(DebugOptions).experiments or []
+ if 'use_runner_v2' in experiments:
Review comment:
We have a method apiclient.use_unified_worker. We can use that instead of
checking it explicitly.
Also, we can simplify/remove that method if we sanitize the options here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
