lukecwik commented on a change in pull request #11319: [BEAM-9703]Include user
distritribution into metric-dedicated validate runner test.
URL: https://github.com/apache/beam/pull/11319#discussion_r405917573
##########
File path: sdks/python/apache_beam/metrics/execution.py
##########
@@ -106,11 +107,13 @@ def __init__(self, key, committed, attempted):
self.key = key
self.committed = committed
self.attempted = attempted
+ self.committed_only = committed_only
def __eq__(self, other):
return (
self.key == other.key and self.committed == other.committed and
- self.attempted == other.attempted)
+ (self.committed_only or other.committed_only or
+ self.attempted == other.attempted))
Review comment:
This is not what I meant when I suggested a matcher, see
https://github.com/hamcrest/PyHamcrest#writing-custom-matchers for an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
