ibzib commented on a change in pull request #11353: [BEAM-9726] Make region
optional for non-service runner.
URL: https://github.com/apache/beam/pull/11353#discussion_r406369724
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -224,6 +225,9 @@
*/
public static final String PROJECT_ID_REGEXP = "[a-z][-a-z0-9:.]+[a-z0-9]";
+ /** Dataflow service endpoints are expected to match this pattern. */
+ static final String ENDPOINT_REGEXP = "https://[\\S]*googleapis\\.com[/]?";;
Review comment:
I copied this from the Python SDK, so I'm not sure what the source of truth
is. But a quick code search doesn't return any obvious negatives.
https://github.com/apache/beam/blob/ac003b6250f8b6e7dd8455fd5ffea7ded3b85bcd/sdks/python/apache_beam/options/pipeline_options_validator.py#L106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
