lostluck commented on a change in pull request #11327: [BEAM-9642] Add SDF
execution units.
URL: https://github.com/apache/beam/pull/11327#discussion_r405097712
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
##########
@@ -120,11 +120,17 @@ func (n *ParDo) ProcessElement(ctx context.Context, elm
*FullValue, values ...Re
if n.status != Active {
return errors.Errorf("invalid status for pardo %v: %v, want
Active", n.UID, n.status)
}
+
+ return n.ProcessMainInput(&MainInput{Key: *elm, Values: values})
+}
+
+func (n *ParDo) ProcessMainInput(mainIn *MainInput) error {
Review comment:
consider not exporting this, as it's helper function for ProcessElement for
the SDF components. Note that since they're in the same package, the unexported
methods could be used.
Regardless of if it's exported or not, please add a godoc comment why this
needs to be separated out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
