robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers
over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r406465514
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -837,25 +869,59 @@ def process_bundle(self, instruction_id):
op.execution_context = execution_context
op.start()
- # Inject inputs from data plane.
+ # Each data_channel is mapped to a list of expected inputs which includes
+ # both data input and timer input. The data input is identied by
+ # transform_id. The data input is identified by
+ # (transform_id, timer_family_id).
data_channels = collections.defaultdict(
list
) # type: DefaultDict[data_plane.GrpcClientDataChannel, List[str]]
+
+ # Inject data inputs from data plane.
Review comment:
This comment is a bit misleading, as the injection doesn't happen in this
for loop. (Similarly with timers.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
