lukecwik commented on issue #11355: [BEAM-9727] Automatically set required experiment flags for dataflow runner v2. URL: https://github.com/apache/beam/pull/11355#issuecomment-611785115 > > Consider adding the logic here instead: > > https://github.com/apache/beam/blob/79b2d87b59819ee55fb8600e8a845c6ba5b98d64/sdks/python/apache_beam/pipeline.py#L206 > > > > This would add the experiment slightly earlier then when the first ptransform is applied. > > I initially considered to add it into pipeline.py following this check, but feel that the logic is too dataflow-specific to be added here. sgtm, in the worst case we can tell users to use a longer list of experiments if we find a problem later.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
