mwalenia commented on a change in pull request #11122: [BEAM-9346] Improve the
efficiency of TFRecordIO
URL: https://github.com/apache/beam/pull/11122#discussion_r406672878
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##########
@@ -410,13 +412,44 @@ private GatherResults(Coder<ResultT> resultCoder) {
} else {
// Pass results via a side input rather than reshuffle, because we
need to get an empty
// iterable to finalize if there are no results.
- return input
- .getPipeline()
- .apply(Reify.viewInGlobalWindow(input.apply(View.asList()),
ListCoder.of(resultCoder)));
+ return input.apply("ToList", Combine.globally(new
ToListCombineFn<>()));
Review comment:
I'm not sure what's the verdict right now. I think we should revert this and
discuss further steps with repo free of regressions. Tagging @lukecwik for
input about leaving the optimization for global windows. @chamikaramj how do
you think the optional change could be applied? A runtime flag for the runner?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
