mxm commented on issue #11362: [BEAM-9733] Always let ImpulseSourceFunction emit a final watermark URL: https://github.com/apache/beam/pull/11362#issuecomment-612030833 I need to rewrite the FlinkSavepointTest since it assumed different semantics. I think we can use the recently introduced timer output timestamp feature. However, I realized the portable operator needs a slight adjustment to fully support holding back the output timestamp correctly at all times. This is trickier than in the non-portable operator with respect to timers setting new timers; we do not have a direct feedback loop as we have in the non-portable operator. We need an additional check when a timer sets a new timer with a timer output timestamp because we only get to fire that timer after we started a new bundle. Thus, we can't always advance the watermark after we finish bundle execution.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
