lukecwik commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io
URL: https://github.com/apache/beam/pull/11151#discussion_r406855406
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -454,6 +455,7 @@ class BeamModulePlugin implements Plugin<Project> {
google_api_services_clouddebugger :
"com.google.apis:google-api-services-clouddebugger:v2-rev20191003-$google_clients_version",
google_api_services_cloudresourcemanager :
"com.google.apis:google-api-services-cloudresourcemanager:v1-rev20191206-$google_clients_version",
google_api_services_dataflow :
"com.google.apis:google-api-services-dataflow:v1b3-rev20190927-$google_clients_version",
+ google_api_services_healthcare :
"com.google.apis:google-api-services-healthcare:v1alpha2-rev20190901-$google_cloud_healthcare_version",
Review comment:
https://cwiki.apache.org/confluence/display/BEAM/Dependency+Upgrades
Combining the linkage checker with a bunch of precommits and postcommits
gives us the confidence that the change is safe.
The linkage checker is a tool which finds linkage errors by scanning the
classpath and finding missing classes/methods. You run the linkage checker on
all modules before and after your change and show that the linkage errors
reduced or stayed the same. Any new linkage errors need to be followed up and
explained why they are safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
