lukecwik commented on a change in pull request #11122: [BEAM-9346] Improve the
efficiency of TFRecordIO
URL: https://github.com/apache/beam/pull/11122#discussion_r406875232
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##########
@@ -410,13 +412,44 @@ private GatherResults(Coder<ResultT> resultCoder) {
} else {
// Pass results via a side input rather than reshuffle, because we
need to get an empty
// iterable to finalize if there are no results.
- return input
- .getPipeline()
- .apply(Reify.viewInGlobalWindow(input.apply(View.asList()),
ListCoder.of(resultCoder)));
+ return input.apply("ToList", Combine.globally(new
ToListCombineFn<>()));
Review comment:
You could always apply the trigger if it is guaranteed to produce output by
checking what the trigger definition is. I don't think you need a flag.
I'm not sure how much of a holistic picture of the whole WriteFiles
transform was done to see if there is a better way to structure the transforms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
