chamikaramj commented on a change in pull request #11122: [BEAM-9346] Improve
the efficiency of TFRecordIO
URL: https://github.com/apache/beam/pull/11122#discussion_r406877630
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##########
@@ -410,13 +412,44 @@ private GatherResults(Coder<ResultT> resultCoder) {
} else {
// Pass results via a side input rather than reshuffle, because we
need to get an empty
// iterable to finalize if there are no results.
- return input
- .getPipeline()
- .apply(Reify.viewInGlobalWindow(input.apply(View.asList()),
ListCoder.of(resultCoder)));
+ return input.apply("ToList", Combine.globally(new
ToListCombineFn<>()));
Review comment:
Thanks for reverting.
My suggestion was to fork the transform expansion to use GlobalCombine when
specifically requested through a transform parameter (for example see how we
fork TextIO.Read expansion based on withHintMatchesManyFiles()).
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java#L371
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java#L401
I agree that the more flags we add the more confusing it becomes for users.
So we should make sure that there are significant advantages in adding this
option through performance benchmarking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
