tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom 
BQ source read from Avro
URL: https://github.com/apache/beam/pull/11086#discussion_r406968173
 
 

 ##########
 File path: sdks/python/apache_beam/io/gcp/bigquery.py
 ##########
 @@ -609,7 +611,8 @@ def __init__(
       coder=None,
       use_standard_sql=False,
       flatten_results=True,
-      kms_key=None):
+      kms_key=None,
+      backwards_compatible_data_format=None):
 
 Review comment:
   1. Can we use a bool as a default value instead of `None`?
   2. Can we use rename this flag to something that describes the course of 
action, for example: `use_json_data_representation=False` - you can come up 
with a better name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to