lukecwik commented on a change in pull request #11236: [BEAM-7505] Create
SideInput Python Jenkins jobs
URL: https://github.com/apache/beam/pull/11236#discussion_r406949975
##########
File path: .test-infra/jenkins/LoadTestsBuilder.groovy
##########
@@ -54,6 +54,16 @@ class LoadTestsBuilder {
}.join(' ')
}
+ static String parseOptions(Map<String, ?> options, SDK sdk) {
+ normalizeOptions(parseOptions(options), sdk)
+ }
+
+ static String normalizeOptions(String options, SDK sdk) {
+ if (sdk == SDK.PYTHON_37 || sdk == SDK.PYTHON) {
+ options.replace('--streaming=false', '').replace('--streaming=true',
'--streaming')
Review comment:
In Beam Java, you should be able to have `--streaming` and `` instead of
having --streaming=true and --streaming=false so you would be able remove the
normalizeOptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
