robertwb commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] 
Improvements for FnApiRunner
URL: https://github.com/apache/beam/pull/11270#discussion_r407664777
 
 

 ##########
 File path: 
sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py
 ##########
 @@ -367,6 +413,73 @@ def _build_process_bundle_descriptor(self):
         state_api_service_descriptor=self.state_api_service_descriptor(),
         timer_api_service_descriptor=self.data_api_service_descriptor())
 
+  def commit_output_views_to_state(self):
 
 Review comment:
   Not sure what "output views" means. Maybe call this 
commit_side_inputs_to_state as well? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to