pabloem commented on a change in pull request #11389: Refactor the BCJ and capture controls to be more testable URL: https://github.com/apache/beam/pull/11389#discussion_r407684719
########## File path: sdks/python/apache_beam/runners/interactive/options/capture_limiters.py ########## @@ -0,0 +1,70 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Module to condition how Interactive Beam stops capturing data. + +For internal use only; no backwards-compatibility guarantees. +""" + +from __future__ import absolute_import + +import threading + +from apache_beam.runners.interactive import interactive_environment as ie + + +class Limiter: + """Limits an aspect of the caching layer.""" + def is_triggered(self): + # type: () -> bool + + """Returns True if the limiter has triggered.""" Review comment: ```suggestion """Returns True if the limiter has triggered, and caching should stop.""" ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
