soyrice commented on a change in pull request #11182: [BEAM-9650] Add 
PeriodicImpulse Transform and slowly changing side input documentation
URL: https://github.com/apache/beam/pull/11182#discussion_r408198261
 
 

 ##########
 File path: website/src/documentation/patterns/side-inputs.md
 ##########
 @@ -45,4 +45,30 @@ For instance, the following code sample uses a `Map` to 
create a `DoFn`. The `Ma
 ```java
 {% github_sample 
/apache/beam/blob/master/examples/java/src/main/java/org/apache/beam/examples/snippets/Snippets.java
 tag:SideInputPatternSlowUpdateGlobalWindowSnip1
 %}
-```
\ No newline at end of file
+```
+
+
+## Slowly updating side input using windowing
+
+You can read side input pcollection periodically into distinct windows.
+Later, when you apply side input to your main input, windows will be matched 
automatically 1:1.
+This way, you can guarantee side input consistency on the duration of the 
single window.
+
+To do this, you can utilize PeriodicSequence PTransform that will generate 
infinite sequence
 
 Review comment:
   It's probably best to replace "To do this" with "To do ABC" - it'll help the 
reader figure out what "this" refers to. Otherwise, if the reader is just 
skimming the page and starts at this paragraph, they have to read the previous 
paragraph to figure out what the pronoun refers to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to