lukecwik commented on a change in pull request #11409: [BEAM-2939] Update
unbounded source as SDF wrapper to resume successfully.
URL: https://github.com/apache/beam/pull/11409#discussion_r408311596
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
##########
@@ -743,8 +727,6 @@ public boolean tryClaim(UnboundedSourceValue<OutputT>[]
position) {
currentReader.close();
} catch (IOException closeException) {
e.addSuppressed(closeException);
- } finally {
Review comment:
Yes, we keep the reader around and let the gc mechanism get rid of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
