tweise commented on issue #11362: [BEAM-9733] Always let ImpulseSourceFunction emit a final watermark URL: https://github.com/apache/beam/pull/11362#issuecomment-613628419 > We have tests in `ExecutableStageDoFnOperatorTest` (`outputsAreTaggedCorrectly`, `testEnsureDeferredStateCleanupTimerFiring`) and through our integration tests. Admittedly, it would be good to dedicate a test specifically to watermark behavior. There is some coverage here: https://github.com/apache/beam/blob/8db19a4645b8588ce9e046637b7619815169bdb1/runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperatorTest.java#L376 It covers only finish bundle on close though. But a similarly fine-grained test should do (integration tests generally don't provide a signal for this).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
