kamilwu commented on a change in pull request #11236: [BEAM-7505] Create SideInput Python Jenkins jobs URL: https://github.com/apache/beam/pull/11236#discussion_r408769964
########## File path: .test-infra/jenkins/SideInputTestSuite.groovy ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Sextend(template)tware Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy extend(template) the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, sextend(template)tware + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import static LoadTestConfig.extendTemplate + + +class SideInputTestSuite { + static def configurations = { LoadTestConfig template -> [ + extendTemplate(template) { + title 'SideInput 2MB 100 byte records: global window' Review comment: > If the side_input_size is 1000, does that mean the whole side input is 100kb in size and we are accessing it 20,000 times because that is the size of the main input? That's right. Would that be fine to change the size of the main input to 1 so that the side input is accessed only once? This would speed things up and maybe even allow us to set up most of your suggested test scenarios. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
