lukecwik commented on a change in pull request #11396: [BEAM-9742] Add
Configurable FluentBackoff to JdbcIO Write
URL: https://github.com/apache/beam/pull/11396#discussion_r409007908
##########
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -257,6 +258,28 @@ public boolean apply(SQLException e) {
}
}
+ /**
+ * This is the default {@link FluentBackoffConfiguration} that we use to
retry when a {@link
+ * SQLException} occurs.
+ */
+ public static class DefaultFluentBackoffConfiguration implements
FluentBackoffConfiguration {
Review comment:
We can't make FluentBackoff part of the public API surface since it is in
the `util` package. It looks like other IO connectors have been creating their
own `RetryConfiguration` class such as:
SnsIO:
https://github.com/apache/beam/blob/da9e17288e8473925674a4691d9e86252e67d7d7/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sns/SnsIO.java#L262
SolrIO:
https://github.com/apache/beam/blob/da9e17288e8473925674a4691d9e86252e67d7d7/sdks/java/io/solr/src/main/java/org/apache/beam/sdk/io/solr/SolrIO.java#L225
and then converting them to any internal implementation that makes sense.
Making FluentBackoff or a RetryConfiguration public and shared across
implementation might make sense but warrants a discussion on the dev@ mailing
list to see what the community thinks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
